DFI-1577 rework performance test setup #22
Merged
zachhall1234 merged 14 commits intomainfrom Feb 23, 2026
Merged
Conversation
# This is the 1st commit message: DFI-1577 change simulation to use same zRef throughout all subsequent API calls # This is the commit message #2: DFI-1577 WIP # This is the commit message #3: DFI-1577 WIP # This is the commit message #4: DFI-1577 WIP # This is the commit message #5: DFI-1577 test setup refactored # This is the commit message #6: DFI-1577 descreased payload size # This is the commit message #7: DFI-1577 increased number of IsaAccount in single payload to 4000 lines # This is the commit message #8: DFI-1577 increased number of IsaAccount in single payload to 8000 # This is the commit message #9: DFI-1577 create one ndJson payload and reuse # This is the commit message #10: DFI-1577 test with 8000 IsaAccounts # This is the commit message #11: DFI-1577 added logging for memory used # This is the commit message #12: DFI-1577 reduce payload size # This is the commit message #13: DFI-1577 increase xXms & Xmx values and payload size # This is the commit message #14: DFI-1577 stream payload instead of holding payload in memory # This is the commit message #15: DFI-1577 increased payload to 16k ISA accounts # This is the commit message #16: DFI-1577 tidy up # This is the commit message #17: DFI-1577 increase concurrent users to 10 # This is the commit message #18: DFI-1577 increase concurrent users to 10 # This is the commit message #19: DFI-1577 increase concurrent users to 2
zachhall1234
commented
Feb 23, 2026
| .post(s"$disaReturnsHost$disaReturnsRoute#{isaManagerReference}/#{taxYear}/#{month}") | ||
| .headers(headerWithClientIdAndBearerToken) | ||
| .body(StringBody(validNdjsonTestData())) | ||
| .body(RawFileBody(submissionPayloadFilePath)).asJson |
Contributor
Author
There was a problem hiding this comment.
What RawFileBody does:
Open NDJSON file → stream bytes → write to buffer → send
appose to what we was happening previously with StringBody
Load entire file → build giant String → send
This was consuming large amounts of gatlings memory resulting in OOM expections
Contributor
Author
There was a problem hiding this comment.
Can we configure this? Robs comment
| monthly-returns-declaration-journey, | ||
| monthly-reconciliation-report-summary-journey | ||
| submit-monthly-returns, | ||
| nps-report-summary-callback |
Contributor
There was a problem hiding this comment.
are we running 'nps-retrieve-monthly-summary-and-report' later ?
Contributor
Author
There was a problem hiding this comment.
Yep put todos in simulation and created https://jira.tools.tax.service.gov.uk/browse/DFI-1720 here to fully implement the get report reconciliation & test support integration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.